Hi,

for quite a long time now there was a change in version name for 
development version (git from gitorious' main branch of FlightGear) 
which follow the scheme "development  __DATE__".

I haven't found yet how it is done from git for fgdata as the file 
http://gitorious.org/fg/fgdata/blobs/master/version contains 2.7.0 these 
days, but my local clone is "development May 18 2012", for today git 
pull. I had a look in my .git/hooks files and just found nothing.

BTW FlightGear's code check for version following the scheme

#define FLIGHTGEAR_VERSION "development " __DATE__

(from src/Include/version.h:10), which I don't want to discuss here, 
but, if the version continue to follow this scheme, it should be nice to 
change the reading code for $FG_ROOT/version file, in 
$FG_SOURCE/src/Main/fg_init.cxx, too.

I've made the change myself some monthes ago on my local clone, thinking 
that someone would change it "for real" :), but it is not the case.

The change is very simple, at least from my point of view, and shouldn't 
have any side-effect, but as I'm not a C++ guru I maybe miss something, 
here it is:

--- a/src/Main/fg_init.cxx
+++ b/src/Main/fg_init.cxx
@@ -144,7 +144,7 @@ string fgBasePackageVersion() {
      }

      string version;
-    in >> version;
+    getline(in, version);

      return version;
  }

Without this change, the value of the string version is always and only 
"development", so it never match the version created at compilation time 
from src/Include/version.h.

Maybe I miss something trivial here, or I'm the only one facing this 
behaviour. If it is the case, please let me know how I can get correct 
behaviour. I'haven't found anything relevant from fg forums, nor 
mailing-list.

Best regards.

seb

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel

Reply via email to