On Friday, August 03, 2012 12:29:51 Renk Thorsten wrote:
> Just stumbled across this one:
>
> Effects/water.eff now declares png textures for reflection and nose to avoid
> dds. The relevant commit changed the effect file and water_sine.frag but
> didn't change the corresponding lines in water_lightfield.frag which has
> pretty identical normal-generating lines.
>
> dds seems to require to reverse normals (?) - in any case two lines marked
> by 'dds fix' need to be removed in order to restore the expected behaviour.
>
> vNorm = -vNorm; //dds fix
> (...)
> N = -N; //dds fix
>
> If anyone with GIT rights could take care of the change in devel and release
> branch? Thanks!
>
> * Thorsten
Are you sure you're using/looking at the correct fgdata? Looking at the files
here they use the proper uniform to determine if the normalmap is dds, and
reverse the normals only in that case:
water-lightfield.frag
line 321:
if (normalmap_dds > 0)
vNorm = -vNorm; //dds fix
line 369:
if (normalmap_dds > 0)
N = -N; //dds fix
normalmap_dds is set to 1 only by water-dds.eff. It's set to 0 in water.eff,
and used by the lightfield technique properly.
regards,
Emilian
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel
