Hey Werner, THanks for working on all this!
note that very little was changed / added recently, so if stuff got lost on the way to Phoenix, it's probably not because it was added after the split... Where is the source repo for wxPython 2.9.5? hmm... I think the wxWidgets SVN is the place to go for that: http://svn.wxwidgets.org/svn/wx/wxPython/3rdParty/FloatCanvas/ you can also view it thiw way: http://svn.wxwidgets.org/viewvc/wx/wxPython/3rdParty/FloatCanvas/ unfortunately, the ThirdParty section seems to not be under the tags -- and I know I never got around to doing any tagging, so verison might be a bit tricky to identify. Makes me appreciate git all the more. -Chris > I wanted to see if I can > figure out where things have gone wrong and see if there is other stuff. > > Manually comparing 2.9.5 with Phoenix fc.Group I got it working for me, > will update the PR next week, but would be good to know if this is all > or if other stuff is missing in Phoenix. > > Werner > > On 9/18/2015 14:00, Werner wrote: > > Me again, > > > > On 9/18/2015 13:39, Werner wrote: > >> Hi Chris, > >> > >> Another one. > >> > >> Group.AddObject is missing this line: > >> obj._Canvas = self._Canvas > >> > >> Could it be that this was added to FC after Robin copied things to > Phoenix? > > It seems that Group is missing a few things which are in 2.9.5 but not > > Phoenix. > > > > __init__ is missing: > > # this one uses a proprty for _Canvas... > > self._Actual_Canvas = None > > > > for obj in ObjectList: > > self.AddObject(obj, calcBB = False) > > > > And the property stuff for _Canvas is missing: > > ## re-define _Canvas property so that the sub-objects get set up > right > > @property > > def _Canvas(self): > > """ > > getter for the _Canvas property > > """ > > return self._Actual_Canvas > > @_Canvas.setter > > def _Canvas(self, canvas): > > """ > > setter for Canvas property > > """ > > self._Actual_Canvas = canvas > > for obj in self.ObjectList: > > obj._Canvas = canvas > > > > I guess 2.9.5 is correct and somehow things did not get into Phoenix, > > correct? > > > > Werner > >> Werner > >> > >> On 9/18/2015 10:57, Werner wrote: > >>> Hi Chris, > >>> > >>> Found another issue, 'itervalues' has gone in PY3. Following is my > work > >>> around, can you think of a nicer way of doing this? > >>> > >>> if six.PY2: > >>> for Event in self._Canvas.HitDict.itervalues(): > >>> try: > >>> del Event[self.HitColor] > >>> except KeyError: > >>> pass > >>> else: > >>> for Event in self._Canvas.HitDict.values(): > >>> try: > >>> del Event[self.HitColor] > >>> except KeyError: > >>> pass > >>> > >>> > >>> Werner > >>> _______________________________________________ > >>> FloatCanvas mailing list > >>> [email protected] > >>> http://mailman.paulmcnett.com/cgi-bin/mailman/listinfo/floatcanvas > >>> > >> _______________________________________________ > >> FloatCanvas mailing list > >> [email protected] > >> http://mailman.paulmcnett.com/cgi-bin/mailman/listinfo/floatcanvas > >> > > _______________________________________________ > > FloatCanvas mailing list > > [email protected] > > http://mailman.paulmcnett.com/cgi-bin/mailman/listinfo/floatcanvas > > > > _______________________________________________ > FloatCanvas mailing list > [email protected] > http://mailman.paulmcnett.com/cgi-bin/mailman/listinfo/floatcanvas > -- Christopher Barker, Ph.D. Oceanographer Emergency Response Division NOAA/NOS/OR&R (206) 526-6959 voice 7600 Sand Point Way NE (206) 526-6329 fax Seattle, WA 98115 (206) 526-6317 main reception [email protected]
_______________________________________________ FloatCanvas mailing list [email protected] http://mailman.paulmcnett.com/cgi-bin/mailman/listinfo/floatcanvas
