+1 on dropping GCC 2.x support.
On Sep 23, 2010, at 4:12 PM, Albrecht Schlosser wrote:
> Yes, I really mean 2.x !
>
> This code is from FLTK 1.3, src/Fl_win32.cxx, line 1554 ff.:
>
> // Drag-n-drop requires GCC 3.x or a non-GNU compiler...
> #if !defined(__GNUC__) || __GNUC__ >= 3
> // Register all windows for potential drag'n'drop operations
> static char oleInitialized = 0;
> if (!oleInitialized) { OleInitialize(0L); oleInitialized=1; }
> ...
>
>
> As it stands, this would only exclude gcc < 3.x from compiling
> the following code. However, Fl_Native_File_Chooser::showdir()
> calls OleInitialize() unconditionally. Instead of "fixing" this,
> I believe that we could require at least gcc 3.x (other compilers
> are not affected here).
>
> ---
>
> Does anybody think that we still need to support gcc 2.x (or even
> older)? If not, we could remove that __GNUC__ conditional instead
> of adding more at other places to make it consistent.
>
> There are about 15 more hits that test __GNUC__ >= 3 in the
> FLTK 1.3 code. These could probably all be removed as well
> (I didn't check yet, but that should be obvious).
>
> ---
>
> Release dates <http://www.gnu.org/software/gcc/releases.html>
>
> GCC 2.95.3 March 16, 2001
> GCC 3.0 June 18, 2001
> GCC 3.1 May 15, 2002
>
> ---
>
> I vote for dropping gcc 2.x support and removing the #if's to
> simplify the code for FLTK 1.3 and later.
>
> Please give your comments and votes!
>
> Albrecht
>
> P.S. This is only one step to consolidate the code WRT the
> OleInitialize/OleUninitialize problem discussed elsewhere in
> fltk.development.
> _______________________________________________
> fltk-dev mailing list
> [email protected]
> http://lists.easysw.com/mailman/listinfo/fltk-dev
________________________________________
Michael Sweet, Easy Software Products
_______________________________________________
fltk-dev mailing list
[email protected]
http://lists.easysw.com/mailman/listinfo/fltk-dev
