When I removed gcc 2.x support ("__GNUC__>=3" etc.) I found the
following to be the correct formal change (committed in r7814):> Modified: branches/branch-1.3/FL/Fl_Export.H > =================================================================== > --- branches/branch-1.3/FL/Fl_Export.H 2010-11-10 21:18:17 UTC (rev > 7813) > +++ branches/branch-1.3/FL/Fl_Export.H 2010-11-11 08:38:36 UTC (rev > 7814) > @@ -32,7 +32,7 @@ > * The following is only used when building DLLs under WIN32... > */ > > -# if defined(FL_DLL)&& (defined(_MSC_VER) || defined(__MWERKS__) || > defined(__BORLANDC__) || __GNUC__>= 3) > +# if defined(FL_DLL)&& ( defined(_MSC_VER) || defined(__MWERKS__) || > defined(__BORLANDC__) || defined(__GNUC__) ) The question is: wouldn't it be okay to remove this compiler-specific second part, so that this line reads: # if defined(FL_DLL) Reasoning: The comment above the line states that this is for building DLLs under WIN32 only. Do we need to distinguish all the windows compilers then, or (asking the other way around): are there other Windows compilers that we are supporting? I can't imagine that other Windows compilers can't build DLLs or don't need/understand the following # define FL_EXPORT __declspec(dllexport) or # define FL_EXPORT __declspec(dllimport) Any ideas? Albrecht _______________________________________________ fltk-dev mailing list [email protected] http://lists.easysw.com/mailman/listinfo/fltk-dev
