Found odd code in BaseXmlNodeSorter
//Very strange loop. It removes exactly (n-1) div 2 elements. The
direction of loop should be reversed.
for (var i = 0; i < node.ChildNodes.Count; i++)
{
node.RemoveChild(node.ChildNodes[i]);
}
foreach (var child in children)
{
node.AppendChild(child); //Actually this deletes the node before the
insertion if it's in the list.
}
Conclusion: The first loop i think we should either refactor the first
loop to the reversed one or remove it completely.
What do you think?
--
You received this message because you are subscribed to the Google Groups
"Fluent NHibernate" group.
To post to this group, send email to fluent-nhibern...@googlegroups.com.
To unsubscribe from this group, send email to
fluent-nhibernate+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/fluent-nhibernate?hl=en.
