David Henningsson wrote:
> When you say option, do you mean as an #ifdef, or as an
> fluid_settings_xxx option?
Whatever you prefer.
> few days, would you (and the other developers) think that would make
> 1.0.9 wait for that patch or would you rather release 1.0.9 as quick as
> possible?
I think that we should freeze the development for new features and fixes,
until the 1.0.9 release is out.
There is a 2.0 branch for experimental work, though. Maybe Bernat is
interested in your work.
> >> Was the "-i" broken in 1.0.8? The 1.0.8 version I've got here seems to
> >> quit immediately if the -i option is used.
> >
> > It works as expected here. Please provide all the command line arguments,
> > files and other details of your tests.
>
> It's possible I've messed up installed versions here. I will try to
> compile the svn trunk version to see if the problem is reproducible there.
If you are testing your patch with the "-i" option, then yes. It is broken. It
was your implementation of fluid_player_join():
int fluid_player_join(fluid_player_t* player)
{
- return player->timer? fluid_timer_join(player->timer) : FLUID_OK;
+ if (player->timer) {
+ fluid_player_stop(player);
+ }
+ return FLUID_OK;
+/* return player->timer? fluid_timer_join(player->timer) : FLUID_OK;*/
}
Clue: the implementation should honor the comment (*Wait, not stop!*) just
before the function body:
/**
* Wait for a MIDI player to terminate (when done playing).
* @param player MIDI player instance
* @return 0 on success, -1 otherwise
*
*/
Regards,
Pedro
_______________________________________________
fluid-dev mailing list
fluid-dev@nongnu.org
http://lists.nongnu.org/mailman/listinfo/fluid-dev
