Hi Justin,
On 16-Feb-09, at 9:10 AM, Justin Obara wrote:
FLUID-2219, FLUID-2206, FLUID-2180, FLUID-2150, FLUID-2008,
FLUID-1954, FLUID-1952
I've reviewed all these issues, and I give them a +1 for inclusion in
Infusion 0.8. Here are a few specific notes:
* I made a minor tweak to Antranig's fix for FLUID-2008, commenting
out the "body" variable inside the FF2-specific block. It wasn't being
used. I also couldn't resist JSLinting the file. I should have done
this in two separate commits; apologies for the inconvenience.
* Your patch for FLUID-2219 looked good, but I also noticed that
Uploader.html still had references to Gears code in it. I committed a
modified version of your patch that included this change.
* I reviewed Anastasia's change to Michelle's FLUID-2150 fix. It's
trivial from a code perspective, but you and Michelle should double-
check that this is indeed the desired functionality.
* I committed Eli's second patch for FLUID-2008.
* I reviewed FLUID-1954. Since it's not part of Infusion itself, it
probably needn't be on the bug parade, but it looks just fine anyway.
Colin
---
Colin Clark
Technical Lead, Fluid Project
Adaptive Technology Resource Centre, University of Toronto
http://fluidproject.org
_______________________________________________________
fluid-work mailing list - [email protected]
To unsubscribe, change settings or access archives,
see http://fluidproject.org/mailman/listinfo/fluid-work
