That ok - I was just curious. I can commit this then, since its so small. -----Original Message----- From: electBlake [mailto:[email protected]] Sent: Wednesday, April 22, 2009 12:41 PM To: Jacob Farber Cc: fluid-work List Subject: Re: 2 Code Reviews - VULAB
I tried to get a constant in there actually, But, vulab and phpESP are still using 2 configuration files. Alot of functionality is setup in functions that run independent of the system (sigh) so its hard to get both configuration files included in there. I can try again, I just wanted to get something in there as it is a pressing matter. - Blake On 22-Apr-09, at 9:36 AM, Jacob Farber wrote: > Hi Blake, > For VULAB-194, have you thought about using Constants to manage > system urls? > Jacob > > -----Original Message----- > From: [email protected] > [mailto:[email protected] > ] On Behalf Of electBlake > Sent: Tuesday, April 21, 2009 2:05 PM > To: fluid-work List > Subject: 2 Code Reviews - VULAB > > I have 2 patches that would love some code reviewing :) > > 1. http://issues.fluidproject.org/browse/VULAB-193 > - this issue resolves some of the conflicts that arose while I was > trying to sync the svn repo to the website. This is the 2nd repost of > this issue. > > 2. http://issues.fluidproject.org/browse/VULAB-194 > - new patch, basically fixes the url to rascal videos. > > > Thanks, > - Blake > _______________________________________________________ > fluid-work mailing list - [email protected] > To unsubscribe, change settings or access archives, > see http://fluidproject.org/mailman/listinfo/fluid-work _______________________________________________________ fluid-work mailing list - [email protected] To unsubscribe, change settings or access archives, see http://fluidproject.org/mailman/listinfo/fluid-work
