Hi all,
Still working on the custom build, and I have more code for review.
Thanks Colin for your review of postProcessor.php. Of course, I made a
lot of revisions over the week when it was first submitted for review
and unfortunately much of the file has changed since the version you
saw. I have uploaded a fresh version to
http://issues.fluidproject.org/browse/FLUID-2963
It was difficult to only make a small change, as it turned out with
further testing there were some things not working..so along with
returning the 400 error as requested, I made some
further edits to ensure that the file was returned correctly - I have
only tested this locally, and plan to test more thoroughly on the server
after writing the unit tests.
Details of changes:
Added more error checking for things such as successful file opening,
variables set, etc.
Validated the input better - but this will be changing completely as
Justin has noted the inputs will come in a single post string in the
near future and will require parsing.
Responded to your suggestion to return a 400 error.
php filesize function has problems so I changed to use an alternate
function, and the filename being returned was incorrect (fixed that).
TODO - unit tests!
Laurel
--
Laurel A. Williams
Adaptive Technology Resource Centre
University of Toronto
_______________________________________________________
fluid-work mailing list - [email protected]
To unsubscribe, change settings or access archives,
see http://fluidproject.org/mailman/listinfo/fluid-work
