Hello Laurel,
Just finished looking over your latest commits.
It looks good. I like the new layout and the ability to run the
different types of test data.
One thing you could change (I think this is actually something I wrote
before, but can't remember), is in the testSelections function (see
line 35) you can probably put the two if statements into 1. that
should save a few lines of code.
- Justin
On 29-Jul-09, at 3:50 PM, Laurel A. Williams wrote:
Hello all,
I am still still still working on the javascript tests for the
customBuild component. Thanks to Anastasia, Michelle and some
extreme refactoring, I have modified the code to manage multiple
data sets. The refactoring involved pulling out the common code into
separate functions so that the tests could re-use code. What I
haven't done yet is determine if the second data set requires any
more testing or if the common tests that I chose are sufficient -
I'll be thinking about that as I add in further test data sets over
the next days.
I think it is time for another code review.
/incubator/custom-build/trunk/tests/js/customBuild-tests.js
Thanks.
Laurel
--
Laurel A. Williams
Adaptive Technology Resource Centre
University of Toronto
_______________________________________________________
fluid-work mailing list - [email protected]
To unsubscribe, change settings or access archives,
see http://fluidproject.org/mailman/listinfo/fluid-work
_______________________________________________________
fluid-work mailing list - [email protected]
To unsubscribe, change settings or access archives,
see http://fluidproject.org/mailman/listinfo/fluid-work
