Hi Alison, I was just taking a look at your patches for FLUID-3011 - the jQuery UI slider a11y. I love that you've written tests both for your code and to help flesh out the tests for existing code. The 'g' patch has one problem with it - the '"ARIA-valuenow after keydown RIGHT" test appears twice in the patch. Other then that I like both the 'g' and 'h' patches.
Once you've fixed the 'g' patch I think it's time for you to attach these patches to the jQuery UI ticket. I would name the files so that it is obvious what the difference is between them. Also put a comment on their ticket to clarify the purposes of the two patches. And at that point I guess the only thing left for you to do is ping their list again pointing at the patches and explaining why you think 'unittext' is a useful addition to the slider options. Thanks for your work on this! Michelle ------------------------------------------------------ Michelle D'Souza Software Developer, Fluid Project Adaptive Technology Resource Centre University of Toronto _______________________________________________________ fluid-work mailing list - [email protected] To unsubscribe, change settings or access archives, see http://fluidproject.org/mailman/listinfo/fluid-work
