[
https://issues.apache.org/jira/browse/FLUME-721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088014#comment-13088014
]
[email protected] commented on FLUME-721:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1604/
-----------------------------------------------------------
Review request for Flume, Arvind Prabhakar and Eric Sammer.
Summary
-------
This was previously posted at https://review.cloudera.org/r/1894/ and pushed
because of timeout. The patch actually was later then reverted because it had
some problems with imports. Since the previous patch had timed-out as opposed
to being actually reviewed, I'm reposting for review.
FLUME-721: Webapps 'autofindport' feature does not work
This refactors the internal http server so that context are created by a
callback object.
This addresses bug flume-721.
https://issues.apache.org/jira/browse/flume-721
Diffs
-----
flume-core/src/main/java/com/cloudera/flume/agent/FlumeNode.java b8f2b67
flume-core/src/main/java/com/cloudera/flume/master/FlumeMaster.java 5c99c43
flume-core/src/main/java/com/cloudera/util/HttpServerTestUtils.java
PRE-CREATION
flume-core/src/main/java/com/cloudera/util/InternalHttpServer.java 1f41460
flume-core/src/main/java/com/cloudera/util/StatusHttpServer.java 58c0ece
flume-core/src/test/java/com/cloudera/flume/agent/TestNodeJersey.java 2625a99
flume-core/src/test/java/com/cloudera/flume/master/TestMasterJersey.java
146cd33
flume-core/src/test/java/com/cloudera/util/InternalHttpServerTest.java
b6a4cdd
flume-core/src/test/java/com/cloudera/util/TestStatusHttpServer.java ac47ac5
flume-node-web/src/test/java/com/cloudera/flume/agent/TestBootstrap.java
8d241dd
Diff: https://reviews.apache.org/r/1604/diff
Testing
-------
ran tests, they passed.
Thanks,
jmhsieh
> Webapps 'autofindport' feature does not work
> --------------------------------------------
>
> Key: FLUME-721
> URL: https://issues.apache.org/jira/browse/FLUME-721
> Project: Flume
> Issue Type: Bug
> Affects Versions: v0.9.4
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Priority: Critical
> Fix For: v0.9.5
>
> Attachments:
> 0001-FLUME-721-Webapps-autofindport-feature-does-not-work.patch,
> 0001-FLUME-721-Webapps-autofindport-feature-does-not-work.patch
>
>
> This is a regression in the upgrade and changes to the webapps from 0.9.3 to
> 0.9.4. In previous versions the default was to enable an option that
> automatically increment http server port in order if the desired port was had
> something bound to it. This made it easier to run and test multiple physical
> nodes on a single machine.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
