[
https://issues.apache.org/jira/browse/FLUME-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098370#comment-13098370
]
[email protected] commented on FLUME-758:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1716/#review1773
-----------------------------------------------------------
Ship it!
lgtm too.
- Arvind
On 2011-09-05 16:57:00, jmhsieh wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1716/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-05 16:57:00)
bq.
bq.
bq. Review request for Flume, Arvind Prabhakar and Eric Sammer.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. commit 27e37dade789b8f77b313573e33fd8fb4d652405
bq. Author: Jonathan Hsieh <[email protected]>
bq. Date: Sun Sep 4 12:24:27 2011 -0700
bq.
bq. FLUME-758: Test Excludes on maven build doesn't always work
bq.
bq. Surefire 2.8.1 does not allow for lists of excluded tests to be
specified via command line.
bq. We force the build to use surefire 2.6 which does.
bq.
bq. Verions 2.9, 2.8, 2.7.2, 2.7.1 and 2.7 were also tested and they
failed to exclude.
bq.
bq.
bq. This addresses bug flume-758.
bq. https://issues.apache.org/jira/browse/flume-758
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. pom.xml d93d7de
bq.
bq. Diff: https://reviews.apache.org/r/1716/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested against versions specified above.
bq.
bq. Version 2.8.1 based build.
bq. jon@grimlock:~/proj/cdh-flume$ mvn test
-Dtest.exclude.pattern="**/TestA*.java,**/TestF*.java"
bq. ...
bq. -------------------------------------------------------
bq. T E S T S
bq. -------------------------------------------------------
bq. Running dk.brics.automaton.TestAutomaton
bq. Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.089 sec
bq. Running com.cloudera.flume.shell.TestFlumeShell
bq. ...
bq.
bq. Version 2.6 based build.
bq. jon@grimlock:~/proj/cdh-flume$ mvn test
bq. ...
bq. -------------------------------------------------------
bq. T E S T S
bq. -------------------------------------------------------
bq. Running com.cloudera.util.consistenthash.TestConsistentHash
bq. Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.288 sec
bq. Running com.cloudera.flume.master.TestMasterReport
bq. Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.487 sec
bq. Running com.cloudera.flume.agent.diskfailover.TestConcurrentDFOMan
bq. Tests run: 11, Failures: 0, Errors: 0, Skipped: 3, Time elapsed: 17.853 sec
bq. Running com.cloudera.util.TestNetUtils
bq. Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.959 sec
bq. Running com.cloudera.flume.agent.TestEndToEndAckFailureRecovery
bq. ^CDestroying 1 processes
bq. Destroying process..
bq. Destroyed 1 processes
bq.
bq. jon@grimlock:~/proj/cdh-flume$ mvn test
-Dtest.exclude.pattern=**/TestC*.java,**/TestM*.java
bq. ...
bq. Running com.cloudera.util.TestNetUtils
bq. Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.65 sec
bq. Running com.cloudera.flume.agent.TestEndToEndAckFailureRecovery
bq. ^CDestroying 1 processes
bq.
bq.
bq. Thanks,
bq.
bq. jmhsieh
bq.
bq.
> Test Excludes on maven build doesn't always work.
> -------------------------------------------------
>
> Key: FLUME-758
> URL: https://issues.apache.org/jira/browse/FLUME-758
> Project: Flume
> Issue Type: Bug
> Components: Build
> Affects Versions: v0.9.5
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: v0.9.5
>
> Attachments:
> 0001-FLUME-758-Test-Excludes-on-maven-build-doesn-t-alway.patch
>
>
> FLUME-716 added the ability to exclude and include specific builds by using a
> test.exclude.pattern and test.include.pattern maven -D arguments. Exclusion
> was not working properly. This should get fixed so that we can exclude
> multiple tests by adding a
> '-Dtest.exclude.pattern=**/TestFlakyTest.java,**/TestFlakyTest2.java' style
> command line argument.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
