[
https://issues.apache.org/jira/browse/FLUME-762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117917#comment-13117917
]
[email protected] commented on FLUME-762:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1739/#review2213
-----------------------------------------------------------
Ship it!
I had to upgrade to a dedicated machine to get tests to pass cleanly. I'll
take care of the spacing nits before committing.
Thanks Prasad!
- jmhsieh
On 2011-09-20 20:54:45, Prasad Mujumdar wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1739/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-20 20:54:45)
bq.
bq.
bq. Review request for jmhsieh.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. If the source or sink throws an exception, close, reopen and retry it.
This way the flow can continue after minor/recoverable errors.
bq.
bq.
bq. This addresses bug FLUME-762.
bq. https://issues.apache.org/jira/browse/FLUME-762
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
flume-core/src/main/java/com/cloudera/flume/core/connector/DirectDriver.java
0466394
bq. flume-core/src/test/java/com/cloudera/flume/agent/TestFlumeNode.java
9d9e1a5
bq.
flume-core/src/test/java/com/cloudera/flume/agent/diskfailover/TestDiskFailoverDeco.java
a7e2d78
bq.
flume-core/src/test/java/com/cloudera/flume/core/connector/TestDirectDriverExp.java
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/1739/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Prasad
bq.
bq.
> DirectDriver should reopen the source/sink if the append or next throws an
> exception
> ------------------------------------------------------------------------------------
>
> Key: FLUME-762
> URL: https://issues.apache.org/jira/browse/FLUME-762
> Project: Flume
> Issue Type: Improvement
> Components: Node
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
> Attachments: flume-762.patch
>
>
> Currently, if source or sink throws an exception, the driver bails out
> resulting the everything to shut down. Alternately, we can try to close and
> reopen the source or sink, and then attempt to continue. This way we can
> avoid blocking the flow. If the reopen fails, then it can bail out.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
