[
https://issues.apache.org/jira/browse/FLUME-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125976#comment-13125976
]
Arvind Prabhakar commented on FLUME-774:
----------------------------------------
Some feedback on the patch:
1. the new module is directly introduced at the top level as flume-ng-hdfs.
Rather than doing that, I suggest you introduce a top-level module called
flume-ng-sinks and make this a submodule of that. Also, it should be renamed to
flume-hdfs-sink instead.
2. the new module is not yet wired into the top level pom so it won't build
from the top level. Need to modify the pom and introduce it in the ng-profile.
3. the flume-ng-node depends upon this, so its pom needs to be modifed as well
to call out an explicit dependency.
One style suggest - since we are using ${project.version} for internal
dependencies, it will be better to use that instead of explicit versions.
Thanks,
Arvind
> Move HDFS sink into a separate module
> -------------------------------------
>
> Key: FLUME-774
> URL: https://issues.apache.org/jira/browse/FLUME-774
> Project: Flume
> Issue Type: Improvement
> Components: Sinks+Sources
> Affects Versions: NG alpha 1
> Reporter: E. Sammer
> Assignee: Prasad Mujumdar
> Fix For: NG alpha 1
>
> Attachments: Flume-774.patch
>
>
> The HDFS sink is currently in the flume-ng-core maven module. This means that
> Flume core depends on Hadoop. Ideally, we would move this to a separate maven
> module (e.g. flume-ng-hadoop) so this dependency was optional.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
