[
https://issues.apache.org/jira/browse/FLUME-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126713#comment-13126713
]
[email protected] commented on FLUME-209:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2380/#review2553
-----------------------------------------------------------
Mingjie,
Look pretty good.
I noticed a few nits that should be addressed.
flume-core/src/main/java/com/cloudera/flume/handlers/socket/UdpSource.java
<https://reviews.apache.org/r/2380/#comment5729>
change to apache
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
flume-core/src/main/java/com/cloudera/flume/handlers/socket/UdpSource.java
<https://reviews.apache.org/r/2380/#comment5726>
needs ')'
flume-core/src/test/java/com/cloudera/flume/handlers/socket/TestUdpSource.java
<https://reviews.apache.org/r/2380/#comment5730>
change to apache
flume-core/src/test/java/com/cloudera/flume/handlers/socket/TestUdpSource.java
<https://reviews.apache.org/r/2380/#comment5727>
final?
flume-core/src/test/java/com/cloudera/flume/handlers/socket/TestUdpSource.java
<https://reviews.apache.org/r/2380/#comment5728>
Maybe put in finally so that we don't have to hang 30s if this fails or
funny exceptions thrown?
- jmhsieh
On 2011-10-13 07:51:02, Mingjie Lai wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2380/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-13 07:51:02)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. It would be nice to have something listen on a specified udp port and
convert each packet them into flume events. This could be useful for "sensors"
or other simple devices on the network.
bq.
bq.
bq. This addresses bug Flume-209.
bq. https://issues.apache.org/jira/browse/Flume-209
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-core/src/main/java/com/cloudera/flume/conf/SourceFactoryImpl.java
ed7b111
bq.
flume-core/src/main/java/com/cloudera/flume/handlers/socket/UdpSource.java
PRE-CREATION
bq.
flume-core/src/test/java/com/cloudera/flume/handlers/socket/TestUdpSource.java
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/2380/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. TestUdp is added and passed locally.
bq.
bq.
bq. Thanks,
bq.
bq. Mingjie
bq.
bq.
> Raw UDP Packet source.
> ----------------------
>
> Key: FLUME-209
> URL: https://issues.apache.org/jira/browse/FLUME-209
> Project: Flume
> Issue Type: New Feature
> Components: Easy, Sinks+Sources
> Reporter: Jonathan Hsieh
>
> It would be nice to have something listen on a specified udp port and convert
> each packet them into flume events. This could be useful for "sensors" or
> other simple devices on the network.
> This is probably just a simplification of syslogudp.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
