[
https://issues.apache.org/jira/browse/FLUME-831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146617#comment-13146617
]
[email protected] commented on FLUME-831:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2739/#review3119
-----------------------------------------------------------
Ship it!
lgtm
- Prasad
On 2011-11-07 03:53:10, Arvind Prabhakar wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2739/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-07 03:53:10)
bq.
bq.
bq. Review request for Flume, Prasad Mujumdar and Eric Sammer.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Removed the log4j dependency from flume-jdbc-channel module.
bq.
bq.
bq. This addresses bug FLUME-831.
bq. https://issues.apache.org/jira/browse/FLUME-831
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-channels/flume-jdbc-channel/pom.xml 3586253
bq.
flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/JdbcChannel.java
6a3ea42
bq.
bq. Diff: https://reviews.apache.org/r/2739/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Built the modules without any errors.
bq.
bq.
bq. Thanks,
bq.
bq. Arvind
bq.
bq.
> flume-jdbc-channel project has unnecessary direct dependency on log4j API
> -------------------------------------------------------------------------
>
> Key: FLUME-831
> URL: https://issues.apache.org/jira/browse/FLUME-831
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: NG alpha 1
> Reporter: Will McQueen
> Assignee: Arvind Prabhakar
>
> Please use slf4j API instead of direct log4j API. So in
> org.apache.flume.channel.jdbc.JdbcChannel, just change this:
> import org.apache.log4j.Logger;
> private static final Logger LOG = Logger.getLogger(JdbcChannel.class);
> ...to this:
> import org.slf4j.Logger;
> import org.slf4j.LoggerFactory;
> private static final Logger LOG =
> LoggerFactory.getLogger(JdbcChannel.class);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
