> On 2011-11-30 18:04:58, Eric Sammer wrote: > > Maybe a tweak on the log message level - up to you. Otherwise, lgtm!
Thanks for the reivew Eric. My comments follow. > On 2011-11-30 18:04:58, Eric Sammer wrote: > > flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java, > > line 120 > > <https://reviews.apache.org/r/2938/diff/1/?file=60141#file60141line120> > > > > Is this really a warning or just INFO? Will change it before commit. > On 2011-11-30 18:04:58, Eric Sammer wrote: > > flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/DerbySchemaHandler.java, > > line 143 > > <https://reviews.apache.org/r/2938/diff/1/?file=60140#file60140line143> > > > > Should all of these constants (at some future point) be broken out into > > an external properties file for simpler updating? Just food for thought. This is an implementation specific constant. Hence it is private scoped within the schema handler. - Arvind ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2938/#review3579 ----------------------------------------------------------- On 2011-11-27 05:25:12, Arvind Prabhakar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2938/ > ----------------------------------------------------------- > > (Updated 2011-11-27 05:25:12) > > > Review request for Flume and Prasad Mujumdar. > > > Summary > ------- > > This change introduces the ability to create indexes while schema creation > via the derby schema handler. The implementation defaults to the creation of > indexes which can be turned off via configuration. > > > This addresses bug FLUME-821. > https://issues.apache.org/jira/browse/FLUME-821 > > > Diffs > ----- > > > flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java > 7e0b3ac > > flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/DerbySchemaHandler.java > 7b29c7d > > flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java > c1bc400 > > flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/MySQLSchemaHandler.java > 1065ef9 > > flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/SchemaHandler.java > 68946c9 > > flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/TestDerbySchemaHandlerQueries.java > 9ce6d16 > > Diff: https://reviews.apache.org/r/2938/diff > > > Testing > ------- > > All unit tests run successfully. > > > Thanks, > > Arvind > >
