[
https://issues.apache.org/jira/browse/FLUME-823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160203#comment-13160203
]
[email protected] commented on FLUME-823:
-----------------------------------------------------
bq. On 2011-11-30 17:58:44, Eric Sammer wrote:
bq. > flume-ng-node/src/main/java/org/apache/flume/node/Application.java,
lines 135-136
bq. > <https://reviews.apache.org/r/2945/diff/2/?file=60172#file60172line135>
bq. >
bq. > At some point I think we should have a separate properties file for
"static" agent level configuration like this. My guess is that there will be
other global configuration in the future.
Agreed. I used the scheme that was outlined in the JIRA discussion. However,
once we have service infrastructure, it makes sense to separate out such
details into their own separate package/subsystem.
- Arvind
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2945/#review3577
-----------------------------------------------------------
On 2011-11-27 21:49:47, Arvind Prabhakar wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2945/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-27 21:49:47)
bq.
bq.
bq. Review request for Flume and Eric Sammer.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Based on the discussion in FLUME-823, this patch implements the fail-fast
scenario for missing configuration file when invoked from the command line. In
order to circumvent this check the system property "flume.called.from.service"
should be set to a non-null value.
bq.
bq.
bq. This addresses bug FLUME-823.
bq. https://issues.apache.org/jira/browse/FLUME-823
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-core/src/main/java/org/apache/flume/Constants.java PRE-CREATION
bq. flume-ng-node/src/main/java/org/apache/flume/node/Application.java
eabeec1
bq.
bq. Diff: https://reviews.apache.org/r/2945/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Manually verified that if the file specified does not exist the process
exits. If the file is specified but does not contain valid configuration for
the node being configured, a warning is printed on the console.
bq.
bq.
bq. Thanks,
bq.
bq. Arvind
bq.
bq.
> The properties configuration provider should fail if the configuration file
> is not found
> ----------------------------------------------------------------------------------------
>
> Key: FLUME-823
> URL: https://issues.apache.org/jira/browse/FLUME-823
> Project: Flume
> Issue Type: Bug
> Components: Configuration
> Affects Versions: NG alpha 1
> Reporter: Will McQueen
> Assignee: Arvind Prabhakar
> Fix For: NG alpha 2
>
> Attachments: FLUME-823-1.patch
>
>
> When specifying a props file (eg, flume.properties) that doesn't exist, the
> logs don't indicate any failure to read the config file. The configuration
> provider should probably just fail if the config file isn't found.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
