[
https://issues.apache.org/jira/browse/FLUME-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160232#comment-13160232
]
[email protected] commented on FLUME-814:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2701/#review3586
-----------------------------------------------------------
Ship it!
Hi Prasad, my apologies for jumping in late on this review. I have some
feedback below. Considering the time elapsed on this issue, I am ok with going
ahead with the commit and opening follow-up JIRAs to track the issues
highlighted.
flume-ng-core/src/main/java/org/apache/flume/channel/FanoutChannel.java
<https://reviews.apache.org/r/2701/#comment7998>
This can lead to inconsistencies. Calling a roll-back (or any other method)
on a transaction that has not yet begun could lead to leaks.
flume-ng-core/src/main/java/org/apache/flume/channel/FanoutChannel.java
<https://reviews.apache.org/r/2701/#comment7999>
Same as before - calling a close on a transaction that has not begun will
lead to other problems.
- Arvind
On 2011-11-03 22:57:15, Prasad Mujumdar wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2701/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-03 22:57:15)
bq.
bq.
bq. Review request for Arvind Prabhakar and Eric Sammer.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. A new fanout channel is added that contains list of underlying channels
and performs the given operation on all those. A new method added to
channelfactory to create the fanout channel from a list of channels. One can
specify a comma separated list of channels for a sink to create the fanout
bq.
bq.
bq. This addresses bug Flume-814.
bq. https://issues.apache.org/jira/browse/Flume-814
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-core/src/main/java/org/apache/flume/ChannelFactory.java 23194a9
bq.
flume-ng-core/src/main/java/org/apache/flume/channel/DefaultChannelFactory.java
a41085f
bq. flume-ng-core/src/main/java/org/apache/flume/channel/FanoutChannel.java
PRE-CREATION
bq. flume-ng-core/src/main/java/org/apache/flume/channel/MemoryChannel.java
4d8313f
bq.
flume-ng-core/src/test/java/org/apache/flume/channel/TestFanoutChannel.java
PRE-CREATION
bq.
flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java
975eafd
bq. flume-ng-node/src/main/java/org/apache/flume/node/Application.java
4004cba
bq.
bq. Diff: https://reviews.apache.org/r/2701/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. ran all unit tests, added new test for the fanout channel
bq.
bq.
bq. Thanks,
bq.
bq. Prasad
bq.
bq.
> Add support for multiple channels to sources
> --------------------------------------------
>
> Key: FLUME-814
> URL: https://issues.apache.org/jira/browse/FLUME-814
> Project: Flume
> Issue Type: New Feature
> Components: Sinks+Sources
> Affects Versions: NG alpha 1
> Reporter: E. Sammer
> Assignee: Prasad Mujumdar
> Fix For: NG alpha 2
>
> Attachments: FLUME-814.patch
>
>
> Flume NG's architecture and configuration claim sources support multiple
> channels but this isn't currently true. The current implementation limits
> sources to a single channel which precludes fanout behavior.
> This will be a fairly invasive change as it impacts the Source interface.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
