[
https://issues.apache.org/jira/browse/FLUME-827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13161860#comment-13161860
]
[email protected] commented on FLUME-827:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2995/#review3604
-----------------------------------------------------------
Ship it!
+1
One thing I noted during the review which is unrelated is that the sink
implementation is not thread safe. It is not a concern right now, but if we
decide to move to multi-threaded pollable sink runners, that will need to be
addressed.
- Arvind
On 2011-12-02 20:23:44, Eric Sammer wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2995/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-02 20:23:44)
bq.
bq.
bq. Review request for Flume, Arvind Prabhakar and Prasad Mujumdar.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Properly detect RPC failures and reconnect as necessary.
bq.
bq.
bq. This addresses bug FLUME-827.
bq. https://issues.apache.org/jira/browse/FLUME-827
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. i/flume-ng-core/src/test/java/org/apache/flume/sink/TestAvroSink.java
fead54f
bq. i/flume-ng-core/src/main/java/org/apache/flume/sink/AvroSink.java
e1f381d
bq.
bq. Diff: https://reviews.apache.org/r/2995/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. New unit tests that confirm this works given a simple connect, send, kill
server, send, start server, reconnect, deliver use case.
bq. Ran manual tests with a pair of agents handling data during transient
failures. Works!
bq.
bq.
bq. Thanks,
bq.
bq. Eric
bq.
bq.
> Avro client conn failure results in 60-second wait before terminating
> ---------------------------------------------------------------------
>
> Key: FLUME-827
> URL: https://issues.apache.org/jira/browse/FLUME-827
> Project: Flume
> Issue Type: Bug
> Components: Node
> Affects Versions: NG alpha 1
> Reporter: Will McQueen
> Assignee: E. Sammer
> Priority: Blocker
> Fix For: NG alpha 2
>
>
> Launching the avro client when the Flume NG node isn't yet running will
> result in a conn refused error. The client should then shutdown immediately,
> but instead waits for 1 minute before the client is terminated.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
