[
https://issues.apache.org/jira/browse/FLUME-914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186027#comment-13186027
]
Prasad Mujumdar commented on FLUME-914:
---------------------------------------
+1
Changes look good !
Few minor comments -
1) Please rebase the changes. Flume-932 has changed the way you register
sources/sinks. Now you don't need to register the sink in Application.java
2) IRCSink.java - Change tabs to space (ts=2)
3) I guess adding a unit test would be difficult, but please see if there's a
way to add one.
4) We follow code review for any large patch, so please submit it via review
board. I will approve it and commit it to ng branch.
thanks
Prasad
> Port the IRC sink to flume ng
> -----------------------------
>
> Key: FLUME-914
> URL: https://issues.apache.org/jira/browse/FLUME-914
> Project: Flume
> Issue Type: New Feature
> Components: Sinks+Sources
> Reporter: Bruno Mahé
> Assignee: Bruno Mahé
> Attachments: FLUME-914.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
