> On 2012-01-16 21:31:54, Prasad Mujumdar wrote: > > A few space nits, I will take care in the merge. > > I guess with the latest codebase, you won't need to change the > > Application.java. Please rebase and regenerate the patch, I will go ahead > > and commit it. > >
The change to Application.java only cleans up unnecessary imports. Do you want me to remove that change? it's not part of the ticket, but since it was done... - Bruno ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3502/#review4408 ----------------------------------------------------------- On 2012-01-14 05:38:58, Bruno Mahé wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3502/ > ----------------------------------------------------------- > > (Updated 2012-01-14 05:38:58) > > > Review request for Flume. > > > Summary > ------- > > Add a IRC sink to flume-ng > > > This addresses bug FLUME-914. > https://issues.apache.org/jira/browse/FLUME-914 > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/sink/SinkType.java 5be602a > flume-ng-dist/pom.xml 5c20252 > flume-ng-node/pom.xml c0e295c > flume-ng-node/src/main/java/org/apache/flume/node/Application.java 07151d1 > flume-ng-sinks/flume-irc-sink/pom.xml PRE-CREATION > > flume-ng-sinks/flume-irc-sink/src/main/java/org/apache/flume/sink/irc/IRCSink.java > PRE-CREATION > flume-ng-sinks/pom.xml 044bf8e > pom.xml 6002358 > > Diff: https://reviews.apache.org/r/3502/diff > > > Testing > ------- > > * All unit tests pass > * Started a Flume node with an irc sink and confirmed it worked > > > Thanks, > > Bruno > >
