[
https://issues.apache.org/jira/browse/FLUME-939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13196500#comment-13196500
]
Bruno Mahé commented on FLUME-939:
----------------------------------
Thanks! Patch look good to me. Although I would have put the message as INFO :)
nitpick:
{noformat}
+ [ -n "$JAVA_DEFAULT" ] || error "Unable to find java executable. Is it
in your PATH?" 1
+ JAVA_BIN=`dirname $JAVA_DEFAULT`
+ JAVA_HOME=`dirname $JAVA_BIN`
{noformat}
Seem to have some indentation issue.
> Load flume-env.sh from flume_conf_dir environment variable / system property
> as opposed to bin directory
> ---------------------------------------------------------------------------------------------------------
>
> Key: FLUME-939
> URL: https://issues.apache.org/jira/browse/FLUME-939
> Project: Flume
> Issue Type: Improvement
> Components: Shell
> Affects Versions: v1.0.0
> Reporter: Karthik K
> Attachments: FLUME-939-ng.patch, FLUME-939.patch
>
>
> When frequently trying out different installations / upgrades of flume, more
> than not, the flume installation directory (including ./bin) is nuked and
> replaced with an updated version for testing, but the flume settings are
> usually stored under FLUME_CONF_DIR , independently to preserve the settings.
> In the current code, the flume-env.sh(.template) is present in BINDIR to
> override.
> We want to provide a mechanism, to source from FLUME_CONFIG_DIR/flume-env.sh
> though, (if present) while being backward compatible still.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
