----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3701/#review4702 -----------------------------------------------------------
Thanks for the patch Prasad. A couple of high-level points of feedback: 1. Please remove the thrift compiler dependency. Instead, my strong suggestion is to check in the generated code into the necessary modules. That way we will not have any issues creating binaries during the release time. Also, along with the removal of compiler, please remove the newly added profile as well. 2. Regarding the newly introduced modules/code, I suggest we do not use the terms OG/NG anywhere. Instead, you can term the modules as Compatibility related indicating their intent. The terms OG/NG are informal names given to the different branches and should not be codified into the system imo. Thanks, Arvind - Arvind On 2012-01-31 05:46:56, Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3701/ > ----------------------------------------------------------- > > (Updated 2012-01-31 05:46:56) > > > Review request for Flume and Eric Sammer. > > > Summary > ------- > > Added thrift and sources to process flume-og thrift event formats. > Flume OG clients can send events directly to these NG sources. Also Flume OG > agents can configure the rcpSinks to send events to these NG sinks. > > > This addresses bug FLUME-942. > https://issues.apache.org/jira/browse/FLUME-942 > > > Diffs > ----- > > flume-og-sources/flume-avroOG-source/pom.xml PRE-CREATION > flume-og-sources/flume-avroOG-source/src/main/avro/flumeOG.avdl > PRE-CREATION > > flume-og-sources/flume-avroOG-source/src/main/java/org/apache/flume/source/avroOG/AvroOGSource.java > PRE-CREATION > > flume-og-sources/flume-avroOG-source/src/test/java/org/apache/flume/source/avroOG/TestOGAvroSource.java > PRE-CREATION > flume-og-sources/flume-thriftOG-source/pom.xml PRE-CREATION > > flume-og-sources/flume-thriftOG-source/src/main/java/org/apache/flume/source/thriftOG/ThriftOGSource.java > PRE-CREATION > flume-og-sources/flume-thriftOG-source/src/main/thrift/flumeOG.thrift > PRE-CREATION > > flume-og-sources/flume-thriftOG-source/src/test/java/org/apache/flume/source/thriftOG/TestThriftOGSource.java > PRE-CREATION > flume-og-sources/pom.xml PRE-CREATION > pom.xml 2bf32bb > > Diff: https://reviews.apache.org/r/3701/diff > > > Testing > ------- > > Regression tests > Added tests for the new sinks > Manually tested event transfer from OG agents to NG thrift and avro sources. > > > Thanks, > > Prasad > >
