[
https://issues.apache.org/jira/browse/FLUME-942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197035#comment-13197035
]
[email protected] commented on FLUME-942:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3701/#review4702
-----------------------------------------------------------
Thanks for the patch Prasad. A couple of high-level points of feedback:
1. Please remove the thrift compiler dependency. Instead, my strong suggestion
is to check in the generated code into the necessary modules. That way we will
not have any issues creating binaries during the release time. Also, along with
the removal of compiler, please remove the newly added profile as well.
2. Regarding the newly introduced modules/code, I suggest we do not use the
terms OG/NG anywhere. Instead, you can term the modules as Compatibility
related indicating their intent. The terms OG/NG are informal names given to
the different branches and should not be codified into the system imo.
Thanks,
Arvind
- Arvind
On 2012-01-31 05:46:56, Prasad Mujumdar wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3701/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-31 05:46:56)
bq.
bq.
bq. Review request for Flume and Eric Sammer.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Added thrift and sources to process flume-og thrift event formats.
bq. Flume OG clients can send events directly to these NG sources. Also Flume
OG agents can configure the rcpSinks to send events to these NG sinks.
bq.
bq.
bq. This addresses bug FLUME-942.
bq. https://issues.apache.org/jira/browse/FLUME-942
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-og-sources/flume-avroOG-source/pom.xml PRE-CREATION
bq. flume-og-sources/flume-avroOG-source/src/main/avro/flumeOG.avdl
PRE-CREATION
bq.
flume-og-sources/flume-avroOG-source/src/main/java/org/apache/flume/source/avroOG/AvroOGSource.java
PRE-CREATION
bq.
flume-og-sources/flume-avroOG-source/src/test/java/org/apache/flume/source/avroOG/TestOGAvroSource.java
PRE-CREATION
bq. flume-og-sources/flume-thriftOG-source/pom.xml PRE-CREATION
bq.
flume-og-sources/flume-thriftOG-source/src/main/java/org/apache/flume/source/thriftOG/ThriftOGSource.java
PRE-CREATION
bq. flume-og-sources/flume-thriftOG-source/src/main/thrift/flumeOG.thrift
PRE-CREATION
bq.
flume-og-sources/flume-thriftOG-source/src/test/java/org/apache/flume/source/thriftOG/TestThriftOGSource.java
PRE-CREATION
bq. flume-og-sources/pom.xml PRE-CREATION
bq. pom.xml 2bf32bb
bq.
bq. Diff: https://reviews.apache.org/r/3701/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Regression tests
bq. Added tests for the new sinks
bq. Manually tested event transfer from OG agents to NG thrift and avro
sources.
bq.
bq.
bq. Thanks,
bq.
bq. Prasad
bq.
bq.
> Support event compatibility with Flume 0.9x
> -------------------------------------------
>
> Key: FLUME-942
> URL: https://issues.apache.org/jira/browse/FLUME-942
> Project: Flume
> Issue Type: New Feature
> Components: Sinks+Sources
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
>
> Support a thrift and avro source that accepts event from flume 0.9x and
> forwards it to Flume NG event flow.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
