----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3698/#review4743 -----------------------------------------------------------
Ship it! lgtm - Prasad On 2012-01-30 22:37:38, Arvind Prabhakar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3698/ > ----------------------------------------------------------- > > (Updated 2012-01-30 22:37:38) > > > Review request for Flume and Prasad Mujumdar. > > > Summary > ------- > > Removed the FanoutChannel and JsonFileConfigurationProvider implementation. > > > This addresses bug FLUME-940. > https://issues.apache.org/jira/browse/FLUME-940 > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/channel/ChannelType.java > b9ce7a5 > flume-ng-core/src/main/java/org/apache/flume/channel/FanoutChannel.java > ca21794 > flume-ng-core/src/test/java/org/apache/flume/channel/TestFanoutChannel.java > ada9a72 > > flume-ng-node/src/main/java/org/apache/flume/conf/file/JsonFileConfigurationProvider.java > f48e681 > > flume-ng-node/src/test/java/org/apache/flume/conf/file/TestJsonFileConfigurationProvider.java > ce4e752 > > flume-ng-node/src/test/java/org/apache/flume/conf/properties/TestPropertiesFileConfigurationProvider.java > 2b1599d > > Diff: https://reviews.apache.org/r/3698/diff > > > Testing > ------- > > Ran all unit tests. > > > Thanks, > > Arvind > >
