[
https://issues.apache.org/jira/browse/FLUME-940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197609#comment-13197609
]
[email protected] commented on FLUME-940:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3698/#review4743
-----------------------------------------------------------
Ship it!
lgtm
- Prasad
On 2012-01-30 22:37:38, Arvind Prabhakar wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3698/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-30 22:37:38)
bq.
bq.
bq. Review request for Flume and Prasad Mujumdar.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Removed the FanoutChannel and JsonFileConfigurationProvider implementation.
bq.
bq.
bq. This addresses bug FLUME-940.
bq. https://issues.apache.org/jira/browse/FLUME-940
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-core/src/main/java/org/apache/flume/channel/ChannelType.java
b9ce7a5
bq. flume-ng-core/src/main/java/org/apache/flume/channel/FanoutChannel.java
ca21794
bq.
flume-ng-core/src/test/java/org/apache/flume/channel/TestFanoutChannel.java
ada9a72
bq.
flume-ng-node/src/main/java/org/apache/flume/conf/file/JsonFileConfigurationProvider.java
f48e681
bq.
flume-ng-node/src/test/java/org/apache/flume/conf/file/TestJsonFileConfigurationProvider.java
ce4e752
bq.
flume-ng-node/src/test/java/org/apache/flume/conf/properties/TestPropertiesFileConfigurationProvider.java
2b1599d
bq.
bq. Diff: https://reviews.apache.org/r/3698/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Ran all unit tests.
bq.
bq.
bq. Thanks,
bq.
bq. Arvind
bq.
bq.
> Remove unused code from Flume
> -----------------------------
>
> Key: FLUME-940
> URL: https://issues.apache.org/jira/browse/FLUME-940
> Project: Flume
> Issue Type: Task
> Affects Versions: v1.0.0
> Reporter: Arvind Prabhakar
> Assignee: Arvind Prabhakar
> Fix For: v1.1.0
>
> Attachments: FLUME-940-1-svn.diff
>
>
> This includes the FanoutChannel as well as JsonFileConfigurationProvider.
> Since we have these in the history of source control, we can revive them at
> anytime as needed rather than incrementally maintaining and not use them
> going forward.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
