[
https://issues.apache.org/jira/browse/FLUME-923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13198131#comment-13198131
]
[email protected] commented on FLUME-923:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3723/#review4756
-----------------------------------------------------------
Thanks for the patch Bruno. The implementation needs to be slightly reworked to
ensure thread-safe handling of jmsSession object. What I suggest is that you
refactor the implementation so that:
1. configure() method creates the necessary naming context
2. start() method initializes the connection factory and creates a connection.
3. process() method creates a session, uses it to publish the event and then
commits it.
4. stop() method closes the connection.
Another point of consideration is to enable batch message support in this.
However, that can be done at a later stage via a separate issue.
Thanks
- Arvind
On 2012-02-01 19:02:07, Bruno Mahé wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3723/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-01 19:02:07)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Here is a review form a rebased patch of FLUME-923.
bq. Sorry Dave, reviewboard didn't want your patch. So I re-exported from my
branch
bq.
bq.
bq. This addresses bug FLUME-923.
bq. https://issues.apache.org/jira/browse/FLUME-923
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-core/src/main/java/org/apache/flume/sink/SinkType.java 6b08c09
bq. flume-ng-dist/pom.xml 19f6b0c
bq. flume-ng-node/pom.xml b9b062e
bq. flume-ng-sinks/flume-jms-sink/pom.xml PRE-CREATION
bq.
flume-ng-sinks/flume-jms-sink/src/main/java/org/apache/flume/sink/jms/JMSSink.java
PRE-CREATION
bq.
flume-ng-sinks/flume-jms-sink/src/test/java/org/apache/flume/sink/jms/TestJMSSink.java
PRE-CREATION
bq. flume-ng-sinks/pom.xml b6cf477
bq. pom.xml abee9a5
bq.
bq. Diff: https://reviews.apache.org/r/3723/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Bruno
bq.
bq.
> Implement a JMS sink for Flume NG
> ---------------------------------
>
> Key: FLUME-923
> URL: https://issues.apache.org/jira/browse/FLUME-923
> Project: Flume
> Issue Type: New Feature
> Affects Versions: v1.0.0
> Reporter: Bruno Mahé
> Assignee: Bruno Mahé
> Attachments: FLUME-923-01-13-2.patch, FLUME-923-2.patch,
> FLUME-923-3.patch, FLUME-923-review-2.patch, FLUME-923-review.patch,
> FLUME-923.1.1.0-SNAPSHOT.patch, FLUME-923.patch, jms.conf
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
