----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3809/#review4994 -----------------------------------------------------------
Ship it! +1. Please attach the patch to the jira. - Arvind On 2012-02-08 19:51:57, Mike Percy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3809/ > ----------------------------------------------------------- > > (Updated 2012-02-08 19:51:57) > > > Review request for Flume. > > > Summary > ------- > > 1. Update the SCM URL to have the correct prefix per > http://maven.apache.org/scm/subversion.html > 2. Generate aggregated javadocs (across the sub-modules) at package time > 3. Run Rat at test time instead of verify time so that it will always run > (typically, you would only run the verify phase if you did an mvn install or > deploy) > > > This addresses bug FLUME-958. > https://issues.apache.org/jira/browse/FLUME-958 > > > Diffs > ----- > > pom.xml e4b40ab > > Diff: https://reviews.apache.org/r/3809/diff > > > Testing > ------- > > Tested this patch on pristine source + FLUME-957. > > 1. SCM URL change: "mvn site" no longer fails (note however that the > generated site is not used by the Flume project) > 2. Javadocs: aggregated javadocs are generated by "mvn package" > 3. Rat: "mvn package" leaves rat.txt files in the respective target/ subdirs > of the sub-modules, evidence that it has run. Note that it succeeds only if > the FLUME-957 patch has been applied. > > > Thanks, > > Mike > >
