----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4047/#review5357 -----------------------------------------------------------
flume-ng-sdk/src/main/java/org/apache/flume/api/client/AvroClientBuilder.java <https://reviews.apache.org/r/4047/#comment11660> Maybe you can provide a version of build which simply takes the 2 arguments directly as well. You can simply set the values in the object and then call this version of build(). flume-ng-sdk/src/main/java/org/apache/flume/api/client/DefaultAvroClient.java <https://reviews.apache.org/r/4047/#comment11661> I think close, append and appendBatch should be synchronized. If something like this happens: if(!isConnected) runs in one thread and then some other thread closes it, the append call(in the first thread) is going to try to connect to a transceiver that is closed, even though the append call was made before the close. Similar case is true for appendBatch, also I think. - Hari On 2012-02-24 22:47:13, Mike Percy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4047/ > ----------------------------------------------------------- > > (Updated 2012-02-24 22:47:13) > > > Review request for Flume. > > > Summary > ------- > > Seeking early feedback on some additional APIs to make integrating with Flume > 1.x easier. > > Added the following APIs: > - AvroClient: Friendly Java interface around the Avro API > - AvroClientBuilder: Builder class to allow easy extension of AvroClient > capabilities in the future (i.e. SSL) > - DefaultAvroClient: Implementation of the AvroClient interface > > Created this stuff in a flume-ng-sdk Maven submodule and moved the Event > interface to that submodule. flume-ng-core depends on flume-ng-sdk. > > I also modified AvroSink to use the AvroClient API instead of the bare > AvroSourceProtocol API directly. > > > This addresses bug FLUME-989. > https://issues.apache.org/jira/browse/FLUME-989 > > > Diffs > ----- > > flume-ng-core/pom.xml d753fa1 > flume-ng-core/src/main/avro/flume.avdl 40da3ef > flume-ng-core/src/main/java/org/apache/flume/Event.java a017705 > flume-ng-core/src/main/java/org/apache/flume/sink/AvroSink.java 5440631 > flume-ng-sdk/pom.xml PRE-CREATION > flume-ng-sdk/src/main/avro/flume.avdl PRE-CREATION > flume-ng-sdk/src/main/java/org/apache/flume/Event.java PRE-CREATION > flume-ng-sdk/src/main/java/org/apache/flume/api/client/AvroClient.java > PRE-CREATION > > flume-ng-sdk/src/main/java/org/apache/flume/api/client/AvroClientBuilder.java > PRE-CREATION > > flume-ng-sdk/src/main/java/org/apache/flume/api/client/DefaultAvroClient.java > PRE-CREATION > pom.xml d785762 > > Diff: https://reviews.apache.org/r/4047/diff > > > Testing > ------- > > > Thanks, > > Mike > >
