I haven't looked at the patch yet but I see us breaking a lot of things out into separate modules. Please be 100% sure this doesn't create any circular dependencies between modules. Also, let's make sure we have damn good reasons for doing this.
Thanks. On Feb 29, 2012, at 8:19 PM, Hari Shreedharan <[email protected]> wrote: > Nope. I had forked my branch more than a day ago and didn't pull since then. > I will rebase the batch once I get some feedback. I actually moved Context to > a new package, so there will be some more changes to make. > > Thanks > Hari > > -- > Hari Shreedharan > > > On Wednesday, February 29, 2012 at 7:53 PM, Brock Noland wrote: > >> Hi, >> >> I don't have time at the moment for a proper review, but it doesn't >> look like the recently checked in Context changes did not make it to >> the new Context? >> >> Brock >
