----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4154/ -----------------------------------------------------------
(Updated 2012-03-02 11:31:56.677014) Review request for Flume. Summary (updated) ------- The javadocs and sample config files are out of date with respect to valid agent configurations. The docs and sample file also mention "host" instead of "agent", which can get confused with the hostname of a machine. The agent name specified in the config file should by convention be named "agent" to make it clearer. An agent name specified in the config file (props file) is what needs to get passed to the '-n' option when running the flume-ng script. The affected code should also be updated to reflect this 'host' to 'agent' change. In the att'd patch, I made some additional small spelling corrections, and fixed some warnings. Diffs ----- flume-ng-core/src/main/java/org/apache/flume/client/avro/AvroCLIClient.java 195ba79 flume-ng-core/src/main/java/org/apache/flume/sink/FailoverSinkProcessor.java 9f5b856 flume-ng-core/src/test/java/org/apache/flume/channel/TestMemoryChannelConcurrency.java 8dad0b2 flume-ng-core/src/test/java/org/apache/flume/channel/TestMemoryChannelTransaction.java bc81f26 flume-ng-legacy-sources/flume-thrift-source/src/test/java/org/apache/flume/source/thriftLegacy/TestThriftLegacySource.java ddd9478 flume-ng-node/src/main/java/org/apache/flume/conf/file/AbstractFileConfigurationProvider.java 64f4e35 flume-ng-node/src/main/java/org/apache/flume/conf/properties/FlumeConfiguration.java d66f6d1 flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 97f72e1 flume-ng-node/src/test/resources/flume-conf.properties 848caca flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java 524b69c Diff: https://reviews.apache.org/r/4154/diff Testing ------- Thanks, Will
