[ 
https://issues.apache.org/jira/browse/FLUME-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225918#comment-13225918
 ] 

[email protected] commented on FLUME-1019:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4175/
-----------------------------------------------------------

(Updated 2012-03-09 07:51:16.055378)


Review request for Flume.


Changes
-------

Made the suggested changes


Summary
-------

An initial pass at documenting the interfaces.
Let me know if I missed anything relevant, or if you feel that this does not 
correctly represent our expected behaviors.


This addresses bug FLUME-1019.
    https://issues.apache.org/jira/browse/FLUME-1019


Diffs (updated)
-----

  flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java 
10f9f4e 
  flume-ng-core/src/main/java/org/apache/flume/Sink.java 3abeeb6 
  flume-ng-core/src/main/java/org/apache/flume/SinkProcessor.java 11651ad 
  flume-ng-core/src/main/java/org/apache/flume/sink/SinkGroup.java 2e80a56 

Diff: https://reviews.apache.org/r/4175/diff


Testing
-------

No changes have been made to code


Thanks,

Juhani


                
> Document Sink and related interfaces, defining expected behaviors
> -----------------------------------------------------------------
>
>                 Key: FLUME-1019
>                 URL: https://issues.apache.org/jira/browse/FLUME-1019
>             Project: Flume
>          Issue Type: Improvement
>          Components: Sinks+Sources
>    Affects Versions: v1.0.0, v1.1.0
>            Reporter: Juhani Connolly
>            Assignee: Juhani Connolly
>             Fix For: v1.1.0
>
>         Attachments: FLUME-1019.patch
>
>
> Currently the Sink interface is undocumented and some of the other public 
> interfaces that might be implemented by users for custom sinks/processors are 
> poorly documented.
> In the process of documenting these interfaces, I hope to get input from 
> others on what our expected behavior is.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to