> On 2012-03-11 07:09:15, Mike Percy wrote: > > Hi Brock, great catch on the lack of a catch-all Exception handler in > > SinkRunner. Regarding FatalException, I think it should inherit from > > FlumeException since the other exceptions do except for > > EventDeliveryException, which should probably be changed to do that. (see > > also the thread on flume-dev about checked vs unchecked exceptions... not > > sure if we exactly came to consensus on that and if not we should aim for > > that once and for all to maintain consistency going fwd) > > > > Regarding the use of FatalException, can you elaborate a little on the use > > case for it? When would the system want to allow a Source or Sink to force > > the runner to quit?
I think the use case is that you want to throw a terminal exception such that the sink will not be retried. If implemented, I think that inheriting from FlumeException would make sense. Let me know how you feel about the use case and then I will update the patch appropriately. - Brock ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3980/#review5824 ----------------------------------------------------------- On 2012-02-29 10:42:17, Brock Noland wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3980/ > ----------------------------------------------------------- > > (Updated 2012-02-29 10:42:17) > > > Review request for Flume. > > > Summary > ------- > > Catches, logs, and sleeps when a general exception occurs. This is similar to > PollingSourceRunner. > > > This addresses bug FLUME-984. > https://issues.apache.org/jira/browse/FLUME-984 > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/FatalException.java > PRE-CREATION > > flume-ng-core/src/main/java/org/apache/flume/source/PollableSourceRunner.java > 264fce1 > flume-ng-core/src/main/java/org/apache/flume/SinkRunner.java 9e46d87 > > Diff: https://reviews.apache.org/r/3980/diff > > > Testing > ------- > > All unit tests pass. > > > Thanks, > > Brock > >
