[
https://issues.apache.org/jira/browse/FLUME-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231965#comment-13231965
]
[email protected] commented on FLUME-1035:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4392/#review6063
-----------------------------------------------------------
Ship it!
Attach the patch to the JIRA and I will see if my commit privileges are working.
- Brock
On 2012-03-17 02:03:05, Mike Percy wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4392/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-17 02:03:05)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This patch fixes issues with unit test logging in the SDK.
bq.
bq.
bq. This addresses bug FLUME-1035.
bq. https://issues.apache.org/jira/browse/FLUME-1035
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-sdk/src/test/resources/log4j.properties PRE-CREATION
bq. flume-ng-sdk/pom.xml d1c6adf
bq. flume-ng-sdk/src/test/java/org/apache/flume/api/RpcTestUtils.java
9497a3d
bq.
flume-ng-sdk/src/test/java/org/apache/flume/api/TestNettyAvroRpcClient.java
8c40aa4
bq.
bq. Diff: https://reviews.apache.org/r/4392/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Mike
bq.
bq.
> slf4j error in flume sdk unit tests
> -----------------------------------
>
> Key: FLUME-1035
> URL: https://issues.apache.org/jira/browse/FLUME-1035
> Project: Flume
> Issue Type: Bug
> Affects Versions: v1.1.0, v1.2.0
> Reporter: Mike Percy
> Assignee: Mike Percy
> Fix For: v1.1.0, v1.2.0
>
>
> There is a problem in the SDK unit tests with slf4j where the SDK does not
> include an implementation of SLF4J in the classpath while it uses JUL for
> logging.
> We should make it consistent by using SLF4J and also provide an
> implementation (Log4j) in the classpath for the SDK unit tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
