----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4446/#review6234 -----------------------------------------------------------
Ship it! +1 - Arvind On 2012-03-22 08:48:20, Mike Percy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4446/ > ----------------------------------------------------------- > > (Updated 2012-03-22 08:48:20) > > > Review request for Flume. > > > Summary > ------- > > Simple patch to use optional instead of compile scope for deps used in unit > tests in the SDK. > > We can't use test scope because it transitively affects core which causes the > jars to not be included in the overall assembly. Optional seems to work fine. > > > This addresses bug FLUME-1043. > https://issues.apache.org/jira/browse/FLUME-1043 > > > Diffs > ----- > > flume-ng-sdk/pom.xml c8fb582 > > Diff: https://reviews.apache.org/r/4446/diff > > > Testing > ------- > > Unit tests pass, able to run binary build with sample config. > > > Thanks, > > Mike > >
