[
https://issues.apache.org/jira/browse/FLUME-881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238080#comment-13238080
]
[email protected] commented on FLUME-881:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3146/#review6343
-----------------------------------------------------------
Ship it!
+1
- Arvind
On 2012-03-25 16:59:47, Jarek Cecho wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3146/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-25 16:59:47)
bq.
bq.
bq. Review request for Flume, Arvind Prabhakar and Eric Sammer.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. I've put "dynamic default value" as is described in the JIRA. Please note
that this patch is not working properly without patch from FLUME-880.
bq.
bq.
bq. This addresses bug FLUME-881.
bq. https://issues.apache.org/jira/browse/FLUME-881
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
/trunk/flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java
1305074
bq.
bq. Diff: https://reviews.apache.org/r/3146/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. I've tested it on my test cluster, no formal tests were included.
bq.
bq.
bq. Thanks,
bq.
bq. Jarek
bq.
bq.
> Would be nice if HDFS Sink would automatically choose best writableFormat
> based on fileType
> -------------------------------------------------------------------------------------------
>
> Key: FLUME-881
> URL: https://issues.apache.org/jira/browse/FLUME-881
> Project: Flume
> Issue Type: Improvement
> Components: Sinks+Sources
> Affects Versions: v1.0.0, v1.1.0
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Priority: Minor
> Attachments: FLUME-881.patch
>
>
> Currently user can specify both file type (SequenceFile, DataStream, ...) and
> writable format (Text ~ append new line character, Writable ~ serialize as
> is) of HDFS sink output file. Both properties have default values, however
> when user redefine only file type to DataStream, flume will still use default
> Writable writable format that will not append separate serialized events with
> new line character.
> Would be nice if flume would choose default value of writable format based on
> current file type, so that for example for DataStream file type, default
> writable format would be Text instead of Writable. I believe that would lead
> to less confused users.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
