[
https://issues.apache.org/jira/browse/FLUME-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238883#comment-13238883
]
[email protected] commented on FLUME-1047:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4488/#review6376
-----------------------------------------------------------
Corrected the review field and attached the patch to the Jira. Thanks Brock!
- Mike
On 2012-03-26 21:46:26, Mike Percy wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4488/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-26 21:46:26)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Created a static utility method to do the HexDump that the LoggerSink uses
as output for events. This lives in the core so that the SDK no longer has any
undeclared dependencies.
bq.
bq.
bq. This addresses bug FLUME-1047.
bq. https://issues.apache.org/jira/browse/FLUME-1047
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-core/src/main/java/org/apache/flume/event/EventHelper.java
PRE-CREATION
bq. flume-ng-core/src/main/java/org/apache/flume/sink/LoggerSink.java
f6f9d33
bq. flume-ng-core/src/test/java/org/apache/flume/event/TestEventHelper.java
PRE-CREATION
bq. flume-ng-sdk/src/main/java/org/apache/flume/event/SimpleEvent.java
9099206
bq. flume-ng-sdk/src/test/java/org/apache/flume/event/TestSimpleEvent.java
385cb7e
bq.
bq. Diff: https://reviews.apache.org/r/4488/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. mvn clean package
bq. Unpacked tarball, ran: ./bin/flume-ng node -c conf -f
conf/flume-conf.properties.template -n foo
bq. Lots of stuff dumped to stdout
bq.
bq.
bq. Thanks,
bq.
bq. Mike
bq.
bq.
> Client SDK has dependency on apache commons
> -------------------------------------------
>
> Key: FLUME-1047
> URL: https://issues.apache.org/jira/browse/FLUME-1047
> Project: Flume
> Issue Type: Bug
> Reporter: Mike Percy
> Assignee: Mike Percy
> Attachments: FLUME-1047-4.patch
>
>
> A patch to fix toString of SimpleEvent ended up introducing a dependency on
> apache commons into the client SDK. Between the time the initial patch was
> submitted and when it was committed the SimpleEvent class was factored into
> the client SDK.
> Proposal is to remove toString from SimpleEvent and add this HexDump
> functionality as a utility method in the core.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
