----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4551/#review6552 -----------------------------------------------------------
Changes look good Hari. One comment below: flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/DefaultLogicalNodeManager.java <https://reviews.apache.org/r/4551/#comment14229> We should have the same logic here as well since otherwise if one component fails to start the others will not be attempted. flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/DefaultLogicalNodeManager.java <https://reviews.apache.org/r/4551/#comment14230> Same here as well. - Arvind On 2012-03-29 07:25:45, Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4551/ > ----------------------------------------------------------- > > (Updated 2012-03-29 07:25:45) > > > Review request for Flume. > > > Summary > ------- > > Fixing a bug that causes a bad configuration to never allow reconfiguration. > > > This addresses bug FLUME-1079. > https://issues.apache.org/jira/browse/FLUME-1079 > > > Diffs > ----- > > > flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/DefaultLogicalNodeManager.java > 2c0cff6 > > Diff: https://reviews.apache.org/r/4551/diff > > > Testing > ------- > > Verified using the conf that produced the error. Works ok now. > > > Thanks, > > Hari > >
