----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4565/#review6561 -----------------------------------------------------------
Ship it! +1. Please attach the patch to the Jira. nit: we should add the console appender as well since up until now the output was visible on the console only. - Arvind On 2012-03-30 00:54:39, Mike Percy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4565/ > ----------------------------------------------------------- > > (Updated 2012-03-30 00:54:39) > > > Review request for Flume. > > > Summary > ------- > > Simple patch to default to a reasonably-configured rolling file appender. > > > This addresses bug FLUME-1073. > https://issues.apache.org/jira/browse/FLUME-1073 > > > Diffs > ----- > > conf/log4j.properties 3dcffd4 > > Diff: https://reviews.apache.org/r/4565/diff > > > Testing > ------- > > Did some manual testing, looks fine to me. > > > Thanks, > > Mike > >
