----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4509/#review6568 -----------------------------------------------------------
Just a couple of minor issues with output, otherwise looks good to me flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/FailoverSinkProcessorConfiguration.java <https://reviews.apache.org/r/4509/#comment14249> For consistency you may want to add a warning here that the default value has been assigned flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/FailoverSinkProcessorConfiguration.java <https://reviews.apache.org/r/4509/#comment14250> I'm not entirely sure if this is an accurate representation of the problem... The property itself is not a duplicate, the priority setting is(because priority settings must be unique). - Juhani On 2012-03-27 06:27:55, Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4509/ > ----------------------------------------------------------- > > (Updated 2012-03-27 06:27:55) > > > Review request for Flume. > > > Summary > ------- > > Failover sink processor configuration > > > This addresses bug FLUME-1059. > https://issues.apache.org/jira/browse/FLUME-1059 > > > Diffs > ----- > > > flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/FailoverSinkProcessorConfiguration.java > PRE-CREATION > flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkProcessor.java > 257bab3 > > flume-ng-core/src/main/java/org/apache/flume/sink/FailoverSinkProcessor.java > 066ee37 > > Diff: https://reviews.apache.org/r/4509/diff > > > Testing > ------- > > > Thanks, > > Hari > >
