[
https://issues.apache.org/jira/browse/FLUME-1059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242155#comment-13242155
]
[email protected] commented on FLUME-1059:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4509/#review6568
-----------------------------------------------------------
Just a couple of minor issues with output, otherwise looks good to me
flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/FailoverSinkProcessorConfiguration.java
<https://reviews.apache.org/r/4509/#comment14249>
For consistency you may want to add a warning here that the default value
has been assigned
flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/FailoverSinkProcessorConfiguration.java
<https://reviews.apache.org/r/4509/#comment14250>
I'm not entirely sure if this is an accurate representation of the
problem... The property itself is not a duplicate, the priority setting
is(because priority settings must be unique).
- Juhani
On 2012-03-27 06:27:55, Hari Shreedharan wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4509/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-27 06:27:55)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Failover sink processor configuration
bq.
bq.
bq. This addresses bug FLUME-1059.
bq. https://issues.apache.org/jira/browse/FLUME-1059
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/FailoverSinkProcessorConfiguration.java
PRE-CREATION
bq.
flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkProcessor.java
257bab3
bq.
flume-ng-core/src/main/java/org/apache/flume/sink/FailoverSinkProcessor.java
066ee37
bq.
bq. Diff: https://reviews.apache.org/r/4509/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Hari
bq.
bq.
> failover sink configuration
> ---------------------------
>
> Key: FLUME-1059
> URL: https://issues.apache.org/jira/browse/FLUME-1059
> Project: Flume
> Issue Type: Sub-task
> Reporter: Hari Shreedharan
> Assignee: Hari Shreedharan
> Fix For: v1.2.0
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
