----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4568/#review6569 -----------------------------------------------------------
Prasad, good catch. These are the only two places with a Transaction.commit() and without a catch (Exception e) clause. Looks good to me. - Mike On 2012-03-30 05:33:54, Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4568/ > ----------------------------------------------------------- > > (Updated 2012-03-30 05:33:54) > > > Review request for Flume, Arvind Prabhakar and Mike Percy. > > > Summary > ------- > > Add exception handlers to rollback open transactions in error cases. > > > This addresses bug FLUME-1074. > https://issues.apache.org/jira/browse/FLUME-1074 > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/channel/ChannelProcessor.java > 7e24e32 > flume-ng-core/src/main/java/org/apache/flume/sink/AvroSink.java e231cb8 > > Diff: https://reviews.apache.org/r/4568/diff > > > Testing > ------- > > regression test run > > > Thanks, > > Prasad > >
