> On 2012-03-30 05:50:30, Arvind Prabhakar wrote: > > flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java, > > line 398 > > <https://reviews.apache.org/r/4569/diff/1/?file=97555#file97555line398> > > > > Since the code is now catching Throwable, please modify the throw logic > > to test and rethrow any Error types. For example: > > > > } catch (Throwable th) { > > ... > > if (th instance of Error) { > > throw (Error) th; > > } else { > > throw new EventDeliveryException(th); > > } > > }
+1 - Brock ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4569/#review6567 ----------------------------------------------------------- On 2012-03-30 05:38:44, Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4569/ > ----------------------------------------------------------- > > (Updated 2012-03-30 05:38:44) > > > Review request for Flume, Arvind Prabhakar and Hari Shreedharan. > > > Summary > ------- > > Unhandled thorwable in HDFS sink can leave transaction open. > > > This addresses bug FLUME-1075. > https://issues.apache.org/jira/browse/FLUME-1075 > > > Diffs > ----- > > > flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java > eee9221 > > Diff: https://reviews.apache.org/r/4569/diff > > > Testing > ------- > > regression tests > > > Thanks, > > Prasad > >
