> On 2012-03-30 20:28:46, Mike Percy wrote: > > Hi Brock, looks great except that it allows the shell environment to > > specify $FLUME_CLASSPATH. The intention was to enforce that they come from > > conf/flume-env.sh. Please restore the line that initializes > > FLUME_CLASSPATH="" > > > > One nit: whitespace at the end of line 107 > > Brock Noland wrote: > Related projects such as hadoop and hbase allow you to append to the > classpath via HADOOP_CLASSPATH and HBASE_CLASSPATH from the command line. > e.g.: > > env HADOOP_CLASSPATH=/tmp/classpath/entry.jar hadoop command > > Is there a reason we don't want to be compatible? > > Mike Percy wrote: > The difference is that the "hadoop" command is a client command-line > tool, but the flume-ng script is primarily a startup script for the agent > daemon. It's bad practice to start daemons using environment variables since > it's not visible in "ps" and not reliably reproducible. So I would prefer not > to support it. If you feel that it's an important feature that makes flume > easier to use then I'm willing to let it go but I think it's a bad way to run > a service.
I am fine with this approach, I updated the patch. FWIW, the hadoop command is used to start all the hadoop daemons. - Brock ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4574/#review6588 ----------------------------------------------------------- On 2012-03-30 21:37:10, Brock Noland wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4574/ > ----------------------------------------------------------- > > (Updated 2012-03-30 21:37:10) > > > Review request for Flume. > > > Summary > ------- > > Attached changes FLUME_CLASSPATH to append to the classpath like > HADOOP_CLASSPATH and HBASE_CLASSPATH do. > > > This addresses bug FLUME-1078. > https://issues.apache.org/jira/browse/FLUME-1078 > > > Diffs > ----- > > bin/flume-ng a31f171 > > Diff: https://reviews.apache.org/r/4574/diff > > > Testing > ------- > > Tested from the command line. > > > Thanks, > > Brock > >
