[ 
https://issues.apache.org/jira/browse/FLUME-1073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243808#comment-13243808
 ] 

[email protected] commented on FLUME-1073:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4565/#review6612
-----------------------------------------------------------

Ship it!


+1.

Thanks for the patch Mike. Please attach the patch to the Jira.

- Arvind


On 2012-03-30 21:38:31, Mike Percy wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4565/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-03-30 21:38:31)
bq.  
bq.  
bq.  Review request for Flume.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Simple patch to default to a reasonably-configured rolling file appender.
bq.  
bq.  
bq.  This addresses bug FLUME-1073.
bq.      https://issues.apache.org/jira/browse/FLUME-1073
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    bin/flume-ng a31f171 
bq.    conf/log4j.properties 3dcffd4 
bq.  
bq.  Diff: https://reviews.apache.org/r/4565/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Did some manual testing, looks fine to me.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Mike
bq.  
bq.


                
> Default Log4j configuration file should have a rolling policy
> -------------------------------------------------------------
>
>                 Key: FLUME-1073
>                 URL: https://issues.apache.org/jira/browse/FLUME-1073
>             Project: Flume
>          Issue Type: Task
>    Affects Versions: v1.1.0
>            Reporter: Arvind Prabhakar
>            Assignee: Mike Percy
>             Fix For: v1.2.0
>
>
> Flume Agents are expected to run for indefinite amount of time and will 
> likely generate a lot of information via it's logs. As such, we need to have 
> a log rolling policy in place to ensure that the system does not run out of 
> disk space due to the log file sizes. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to