----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4610/#review6636 -----------------------------------------------------------
Ship it! +1 - Arvind On 2012-04-02 20:32:49, Mike Percy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4610/ > ----------------------------------------------------------- > > (Updated 2012-04-02 20:32:49) > > > Review request for Flume. > > > Summary > ------- > > This patch changes loglevel to debug for stuff like successful event read & > write. This should improve performance at the INFO level. Other similar > changes have been made. > > One additional change I have snuck into this patch is logging the event > metrics at info level for the Null sink, to make it consistent with the > Logger sink. > > > This addresses bug FLUME-1090. > https://issues.apache.org/jira/browse/FLUME-1090 > > > Diffs > ----- > > > flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java > 307ae89 > flume-ng-core/src/main/java/org/apache/flume/sink/NullSink.java c11a002 > > Diff: https://reviews.apache.org/r/4610/diff > > > Testing > ------- > > Unit tests pass. > > > Thanks, > > Mike > >
