[ 
https://issues.apache.org/jira/browse/FLUME-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244591#comment-13244591
 ] 

[email protected] commented on FLUME-1090:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4610/#review6636
-----------------------------------------------------------

Ship it!


+1

- Arvind


On 2012-04-02 20:32:49, Mike Percy wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4610/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-04-02 20:32:49)
bq.  
bq.  
bq.  Review request for Flume.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  This patch changes loglevel to debug for stuff like successful event read 
& write. This should improve performance at the INFO level. Other similar 
changes have been made.
bq.  
bq.  One additional change I have snuck into this patch is logging the event 
metrics at info level for the Null sink, to make it consistent with the Logger 
sink.
bq.  
bq.  
bq.  This addresses bug FLUME-1090.
bq.      https://issues.apache.org/jira/browse/FLUME-1090
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    
flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java
 307ae89 
bq.    flume-ng-core/src/main/java/org/apache/flume/sink/NullSink.java c11a002 
bq.  
bq.  Diff: https://reviews.apache.org/r/4610/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Unit tests pass.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Mike
bq.  
bq.


                
> JDBC Channel: Minimize logging under nominal conditions
> -------------------------------------------------------
>
>                 Key: FLUME-1090
>                 URL: https://issues.apache.org/jira/browse/FLUME-1090
>             Project: Flume
>          Issue Type: Improvement
>            Reporter: Mike Percy
>            Assignee: Mike Percy
>             Fix For: v1.2.0
>
>         Attachments: FLUME-1090-1.patch
>
>
> Minimize the logging that we do under normal conditions in JDBC channel, for 
> performance and usability reasons.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to